Add statement ID and session ID wherever possible#844
Merged
samikshya-db merged 3 commits intoJun 3, 2025
Conversation
gopalldb
reviewed
Jun 1, 2025
gopalldb
reviewed
Jun 1, 2025
| .setSqlStatementId( | ||
| statementId | ||
| .toSQLExecStatementId()) // This is because only GUID is relevant for tracking | ||
| .setSessionId(sessionId); |
Collaborator
Author
There was a problem hiding this comment.
yes, in the 2 cases :
- if create session fails for a reason other than auth
- if it is a multiThreaded call
jprakash-db
approved these changes
Jun 3, 2025
jprakash-db
left a comment
jprakash-db
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thanks for the changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
Additional Notes to the Reviewer
NO_CHANGELOG=true